quick/netradiant-custom
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tweak StringOutputStream use

Browse Source 
auto str = StringOutputStream()(bla) use form was not doing copy elision or move, but copy
This commit is contained in:
Garux
2024-01-29 16:54:08 +06:00
parent b4e44bc8ed
commit df02774ff5
122 changed files with 984 additions and 1204 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
radiant/eclass_xml.cpp
View File

@@ -245,7 +245,7 @@ public:
desc = StringRange( data, length );
}
else{ // in case of special symbols, e.g. &quot, &apos, &lt, &gt, &amp, xml writes in a few steps
desc = StringOutputStream()( desc, StringRange( data, length ) );
desc = StringStream( desc, StringRange( data, length ) );
}
return m_comment.write( data, length );
@@ -290,7 +290,8 @@ class ClassImporter : public TreeXMLImporter
ListAttributeTypes& m_listTypes;
public:
ClassImporter( EntityClassCollector& collector, ListAttributeTypes& listTypes, const XMLElement& element ) : m_collector( collector ), m_listTypes( listTypes ){
ClassImporter( EntityClassCollector& collector, ListAttributeTypes& listTypes, const XMLElement& element )
: m_collector( collector ), m_comment( 1024 ), m_listTypes( listTypes ){
m_eclass = Eclass_Alloc();
m_eclass->free = &Eclass_Free;
@@ -305,7 +306,7 @@ public:
const char* model = element.attribute( "model" );
if ( !string_empty( model ) ) {
m_eclass->m_modelpath = StringOutputStream( 256 )( PathCleaned( model ) ).c_str();
m_eclass->m_modelpath = StringStream<64>( PathCleaned( model ) );
}
const char* type = element.name();
@@ -317,7 +318,7 @@ public:
}
}
~ClassImporter(){
m_eclass->m_comments = m_comment.c_str();
m_eclass->m_comments = m_comment;
m_collector.insert( m_eclass );
for ( ListAttributeTypes::iterator i = m_listTypes.begin(); i != m_listTypes.end(); ++i )